[Webkit-unassigned] [Bug 154852] NetworkCache: Web process leaks resource buffer when using shareable reasources

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 1 22:39:59 PST 2016


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
                 CC|                            |ap at webkit.org

--- Comment #5 from Alexey Proskuryakov <ap at webkit.org> ---
I can see how this avoids refcount churn, however I don't see how this can fix a leak. What am I missing?

+        ResourceLoader::didReceiveBuffer() expects a PassRefPtr, but we
+        are passing a raw pointer making PassRefPtr to take another
+        reference instead of transfering the ownership as expected.

This was compensated by the original RefPtr still having a pointer to the object, so there was also one more deref().

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160302/6247831e/attachment.html>

More information about the webkit-unassigned mailing list