[Webkit-unassigned] [Bug 159251] New: RenderBox::hasDefiniteLogicalHeight() shouldn't consider all abspos elements as definite

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159251

            Bug ID: 159251
           Summary: RenderBox::hasDefiniteLogicalHeight() shouldn't
                    consider all abspos elements as definite
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: rego at igalia.com
                CC: jfernandez at igalia.com, rego at igalia.com,
                    simon.fraser at apple.com, svillar at igalia.com

Created attachment 282326
  --> https://bugs.webkit.org/attachment.cgi?id=282326&action=review
Test case to reproduce the issue

An abspos element doesn't have a definite height unless it has a specified height or the top and bottom properties are not auto.

For example, the following div doesn't have a definite height:
  <div style="position: absolute;"></div>

However, this one will have a definite height:
  <div style="position: absolute; top: 0; bottom: 0;"></div>

RenderBox::hasDefiniteLogicalHeight() is considering that both have a definite height which is wrong:
http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderBox.cpp#L4760

This leads to wrong results in CSS Grid Layout check the attached example, the 50% in the 2nd row is resolved against the 100px of the first row when it should be considered "auto".
You can check it live at: http://jsbin.com/xuyane/1/edit?html,css,output

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160629/47bea5d3/attachment.html>