[Webkit-unassigned] [Bug 159224] Use a regex to check if a test step is for JavaScriptCore
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 28 14:44:50 PDT 2016
https://bugs.webkit.org/show_bug.cgi?id=159224
--- Comment #10 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 282286
--> https://bugs.webkit.org/attachment.cgi?id=282286
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=282286&action=review
> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:254
> + else if (/(?=.*test)(?=.*jsc)/.test(step.name) === true)
WebKit coding style calls for no comparison to true, should be just if (/(?=.*test)(?=.*jsc)/.test(step.name))
Sorry for missing it the first time around (I blame Geoff of course).
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160628/bb3a48cf/attachment-0001.html>
More information about the webkit-unassigned
mailing list