[Webkit-unassigned] [Bug 157907] Web Inspector: Snapshots should be cleared at some point

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157907

--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 281793
  --> https://bugs.webkit.org/attachment.cgi?id=281793
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281793&action=review

>> Source/WebCore/inspector/PageHeapAgent.cpp:56
>> +} // namespace WebCore
> 
> Trailing newline?

FWIW: There is a trailing newline, and the diff tool would mention if there wasn't a trailing newline in its own line.

>> Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotWorkerProxy.js:103
>> +        this.clearSnapshots(function() {
> 
> arrow function?

I've been waffling on whether or not to use an arrow function for a simple function that doesn't use `this`. But maybe we should just start using it in more places like inline anonymous functions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160623/efc69402/attachment-0001.html>