[Webkit-unassigned] [Bug 158988] New: Solve the confusion around blankURL() and isBlankURL() in URL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 09:45:48 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=158988

            Bug ID: 158988
           Summary: Solve the confusion around blankURL() and isBlankURL()
                    in URL
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: wilander at apple.com

These two functions in URL are causing confusion:

const URL& blankURL()
{
    static NeverDestroyed<URL> staticBlankURL(ParsedURLString, "about:blank");
    return staticBlankURL;
}

bool URL::isBlankURL() const
{
    return protocolIs("about");
}

We should consolidate into one notion of a blank URL and make sure callers get what they are expecting. This might require a new isAboutURL() function or similar.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160621/03570a2d/attachment.html>


More information about the webkit-unassigned mailing list