[Webkit-unassigned] [Bug 155750] [GTK] Add kinetic scrolling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 03:17:14 PDT 2016


--- Comment #22 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #20)
> Created attachment 281711 [details]
> Patch - new features + bugfix
> I've used this patch in an internal project and made some modifications that
> you may find useful. I am posting the updated patch without ChangeLogs, feel
> free to update it or let me know if you prefer if I do it.
> The changes included in this patch (on top of latest one from Adrien):
> - overshoot animations support (ScrollAnimationKinetic.cpp)
> - bugfix for a crash when starting a drag while scrolling
> (GestureController.cpp)
> - build fix for gtk < 3.20 (PlatformWheelEventGtk.cpp)
> - bugfix for gtk < 3.20 to properly copy NativeWebWheelEvent (is_stop is not
> available in gtk < 3.20 and the phase/momentumPhase were not being properly
> copied on the NativeWebWheelEvent copy constructor, making the page "jump"
> during scroll instead of starting momentum scroll -
> NativeWebWheelEventGtk.cpp)
> - respect scrollbar policy (ScrollAnimationKinetic.cpp +
> ScrollAnimatorGtk.cpp)
> That should be it, please let me know what you think.

Thanks! I think Adrien should include crashes and build fixes in his patch when submitting a new version and you should open a new bug depending on this one to add the overshooting support on top of Adrien's patch.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160621/eece3f13/attachment.html>

More information about the webkit-unassigned mailing list