[Webkit-unassigned] [Bug 158900] Updating class name of a shadow host does not update the style applied by :host()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158900

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 281623
  --> https://bugs.webkit.org/attachment.cgi?id=281623
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281623&action=review

> Source/WebCore/style/AttributeChangeInvalidation.cpp:42
> +    if (shadowRuleSets.authorStyle()->hostPseudoClassRules().isEmpty())
> +        return false;

Is there a solid guarantee that authorStyle is non-null? I noticed this pattern repeating in the code so the question applies not just here but at many other sites too.

> Source/WebCore/style/AttributeChangeInvalidation.cpp:61
> +    auto* shadowRoot = m_element.shadowRoot();
> +    if (shadowRoot && mayBeAffectedByHostStyle(*shadowRoot, isHTML, attributeName))
> +        mayAffectStyle = true;

Can we skip this work if mayAffectStyle is already true?

> Source/WebCore/style/ClassChangeInvalidation.cpp:108
> +        if (shadowRoot && mayBeAffectedByHostStyle(*shadowRoot, changedClass))
> +            mayAffectStyle = true;

Can we skip this work if mayAffectStyle is already true?

> Source/WebCore/style/IdChangeInvalidation.cpp:57
> +    auto* shadowRoot = m_element.shadowRoot();
> +    if (shadowRoot && mayBeAffectedByHostStyle(*shadowRoot, changedId))
> +        mayAffectStyle = true;

Can we skip this work if mayAffectStyle is already true?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160619/35cf5eef/attachment.html>