[Webkit-unassigned] [Bug 153499] Web Inspector: console.profile should use the new Sampling Profiler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153499

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #281316|review?                     |review+
              Flags|                            |

--- Comment #6 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 281316
  --> https://bugs.webkit.org/attachment.cgi?id=281316
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=281316&action=review

Very clean!

> Source/JavaScriptCore/inspector/agents/InspectorScriptProfilerAgent.cpp:223
> +}
> +void InspectorScriptProfilerAgent::programmaticCaptureStopped()

Newline.

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:249
> +    // Allow duplicate unnamed profiles. Disallow duplicate named profiles.
> +    if (!title.isEmpty()) {

Sad this needs duplicated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160616/6b9d634d/attachment.html>