[Webkit-unassigned] [Bug 158672] New: Asserts-enabled builds fails because JSC::JSCell::inherits is not defined

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158672

            Bug ID: 158672
           Summary: Asserts-enabled builds fails because
                    JSC::JSCell::inherits is not defined
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jeremyhu at apple.com

Recent master (r201265, b077d8fac8360fe5406bf13a44bbeff9acb0f9ea) fails to build with the following link error:

Undefined symbols for architecture x86_64:
  "JSC::JSCell::inherits(JSC::ClassInfo const*) const", referenced from:
      JSC::CodeBlock::ownerScriptExecutable() const in FTLCapabilities.cpp.o
ld: symbol(s) not found for architecture x86_64

We see the usage here:

bytecode/CodeBlock.h:
ScriptExecutable* ownerScriptExecutable() const { return jsCast<ScriptExecutable*>(m_ownerExecutable.get()); }

with jsCast implemented here, showing the JSC::JSCell::inherits call 

runtime/JSCell.h:
template<typename To, typename From>
inline To jsCast(From* from)
{
    ASSERT_WITH_SECURITY_IMPLICATION(!from || from->JSCell::inherits(std::remove_pointer<To>::type::info()));
    return static_cast<To>(from);
}

If asserts are disabled and SECURITY_ASSERTIONS are disabled, ASSERT_WITH_SECURITY_IMPLICATION is a no-op, and this could go unnoticed, but if the assertions are enabled, the build fails because JSCell.cpp does not implement JSC::JSCell::inherits(JSC::ClassInfo const*) const.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160612/d7ae0615/attachment.html>