[Webkit-unassigned] [Bug 158083] LLInt should support other types of prototype GetById caching.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 11 14:42:03 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=158083

--- Comment #48 from Saam Barati <sbarati at apple.com> ---
(In reply to comment #46)
> (In reply to comment #45)
> > The m_unlikedCode stores the identifiers into a Vector<Identifier>
> > m_identifiers. The problem is to revive the identifier contained in the
> > Vector buffer. My current implementation is like this
> > 
> > macro loadIdentifier(index, dest)
> >     loadp CodeBlock[cfr], t2
> >     loadp CodeBlock::m_unlinkedCode[t2], t1 #t1 is pointing to
> > UnlinkedCodeBlock
> >     addp UnlinkedCodeBlock::m_identifiers, t1 #Offset to point to
> > m_identifiers
> >     loadis index, t2
> >     mulp sizeof Identifier, t2 
> >     addp t2, t1 # Offset to point to m_identifiers[index]
> >     addp Identifier::m_string, t1 # m_identifiers[index].m_string
> >     loadp t1, dest
> > end 
> > 
> > Any tip?
> 
> Actually, this code working now:
> 
> macro loadIdentifier(index, dest)
>     loadp CodeBlock[cfr], t2
>     loadp CodeBlock::m_unlinkedCode[t2], t1
>     loadp UnlinkedCodeBlock::m_identifiers[t1], t2
>     move t2, t1
>     loadis index, t2
>     mulp sizeof Identifier, t2
>     addp t2, t1
>     loadp Identifier::m_string[t1], dest
> end
> 
> I would like to know if there is a way to test the changes in all
> architectures.
Which architecture are you running locally?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160611/214c9165/attachment.html>


More information about the webkit-unassigned mailing list