[Webkit-unassigned] [Bug 158602] A composition underline is placed to wrong position in RTL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158602

--- Comment #9 from zalan <zalan at apple.com> ---
Comment on attachment 281005
  --> https://bugs.webkit.org/attachment.cgi?id=281005
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281005&action=review

> Source/WebCore/rendering/InlineTextBox.cpp:938
> +        if (!isLeftToRightDirection())
> +            start = m_logicalWidth - width - start;

Do you mind making a helper function for this as now this logic is both at InlineTextBox::paintDecoration and here? (and maybe it's even missing from some of the other painting methods)

There is this 'start += 1;' a few lines below, does it work fine with RTL?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160610/eb40c8cb/attachment.html>