[Webkit-unassigned] [Bug 158364] AX: WKWebView should have API to prevent pinch-to-zoom always being allowed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 8 14:57:29 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=158364

--- Comment #7 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 280478
  --> https://bugs.webkit.org/attachment.cgi?id=280478
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280478&action=review

>>> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2214
>>> +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000
>> 
>> Is all the iOS versioning required? This code will never run on an older device right
> 
> Because we set the property WK_AVAILABLE(NA, 10_0), do you think we should remove that as well?

It seems like that should be kept there so people compiling against different versions know whats there or not, but internally the versioning seems uncessary to me. Maybe someone else has a different opinion

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160608/9c2b2c26/attachment.html>


More information about the webkit-unassigned mailing list