[Webkit-unassigned] [Bug 116046] For keyboard users, activating a fragment URL should transfer focus and caret to the destination

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116046

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #280814|review?                     |review+
              Flags|                            |

--- Comment #55 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 280814
  --> https://bugs.webkit.org/attachment.cgi?id=280814
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280814&action=review

> Source/WebCore/dom/Document.cpp:3952
> +    // The sibling needs to be an element prior to the next focusable element.
> +    if (Element* sibling = direction == FocusDirectionForward ? ElementTraversal::previous(*node) : ElementTraversal::next(*node))

Why don't we declare a local variable with a descriptive name instead of adding a comment?
e.g. elementBeforeNextFocusableElement

> Source/WebCore/page/FrameView.cpp:2108
> +            // Set the focused element to nullptr here so that we can use the focus navigation starting node
> +            // to search for the next focus candidate.

I don't think this comment is necessary. Please remove.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160608/49efd943/attachment.html>