[Webkit-unassigned] [Bug 158083] LLInt should support other types of prototype GetById caching.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158083

--- Comment #39 from Caio Lima <ticaiolima at gmail.com> ---
(In reply to comment #38)
> Comment on attachment 280560 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280560&action=review
> 
> Looks good. I think it's almost ready to go. Saam and I have a few comments
> before the patch is ready to land however.
> 
> > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:659
> > +        if ((slot.isValue() || slot.isAccessor()) && slot.slotBase() == baseValue) {
> 
> Why clear the cache if we have a self accessor? There is no cost to leaving
> the old value cache in place.

I see your point. Actually, the main reason I implemented it was because I though it was the case where handling a cache miss and clearing the old cache. However, if I am not wrong, It is the case just to self accessors, right?

In our implementation, we just cache the prototype once (when pc[7].u.operand reaches 0) and after that, all cache misses are handled by the _llint_get_by_id_proto_acessor opcode slowPath case. The advantage to clear the cache is to avoid all these misses, however, the original _llint_get_by_id_proto_acessor also check for misses and there is no real improvement clearing the cache, right?

I am going to change it.

BTW, I have already an first implementation of CustomAcessors. What I need to finish is inline the CustomAcessor call to Assembly code. I think it is a good idea send them in the same patch, since the files touched are the same. As you pointed me instructions to try inline the Getter, I already have an idea what I need to do to complete this implementation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160608/6e58fcce/attachment.html>