[Webkit-unassigned] [Bug 158083] LLInt should support other types of prototype GetById caching.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158083

Keith Miller <keith_miller at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #280560|review?                     |review-
              Flags|                            |

--- Comment #38 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 280560
  --> https://bugs.webkit.org/attachment.cgi?id=280560
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280560&action=review

Looks good. I think it's almost ready to go. Saam and I have a few comments before the patch is ready to land however.

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:659
> +        if ((slot.isValue() || slot.isAccessor()) && slot.slotBase() == baseValue) {

Why clear the cache if we have a self accessor? There is no cost to leaving the old value cache in place.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160608/88f07645/attachment.html>