[Webkit-unassigned] [Bug 116046] For keyboard users, activating a fragment URL should transfer focus and caret to the destination

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116046

--- Comment #50 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 280722
  --> https://bugs.webkit.org/attachment.cgi?id=280722
Patch after the crash fix

View in context: https://bugs.webkit.org/attachment.cgi?id=280722&action=review

>> Source/WebCore/dom/Document.cpp:3725
>> +    }
> 
> It seems that we're storing the focus navigation starting node here so that we can move it to somewhere else in
> updateFocusNavigationStartingNodeWithNodeRemoval later.
> I think it's better and more efficient to call updateFocusNavigationStartingNodeWithNodeRemoval before this function
> in Document::nodeChildrenWillBeRemoved and Document::nodeWillBeRemoved instead.

setFocusedElement(nullptr) will also reset the focusNavigationStartingNode. So that's why updateFocusNavigationStartingNodeWithNodeRemoval needs to be after this function.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160608/0a9909dd/attachment.html>