[Webkit-unassigned] [Bug 71509] WebKit memory cache doesn't respect Vary header

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71509

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #280597|review?                     |review+
              Flags|                            |

--- Comment #19 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 280597
  --> https://bugs.webkit.org/attachment.cgi?id=280597
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280597&action=review

R=me although I wish we simply implemented basic Vary support in the memory cache.

>> Source/WebCore/loader/cache/CachedResource.cpp:762
>> +        // If Vary header is present don't use the memory cache entry. Instead fall back to disk cache that knows how to handle it.
> 
> This comment seems a bit odd. In case of memory cache revalidation, we bypass the disk cache.

Oh, I see that you worked around this by tweaking canUseCacheValidator() above. Ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160606/e50263a1/attachment-0001.html>