[Webkit-unassigned] [Bug 158294] New: Refactor showModalDialog handling in JSDOMWindowCustom
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 1 23:43:00 PDT 2016
https://bugs.webkit.org/show_bug.cgi?id=158294
Bug ID: 158294
Summary: Refactor showModalDialog handling in JSDOMWindowCustom
Classification: Unclassified
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Bindings
Assignee: webkit-unassigned at lists.webkit.org
Reporter: barraclough at apple.com
CC: cdumez at apple.com
The way this is currently implemented, for accessing the showModalDialog property there is effectively a duplication of the tail of the function modified to call Base::getOwnPropertySlot instead of getStaticPropertySlot. It does so based on the assumption that Base::getOwnPropertySlot is not going to search the static tables (containing the property we wish to omit).
However as a part of bug #158178 I plan to change it such that Base::getOwnPropertySlot does also search the static tables. Refactor this code to no longer depend on Base::getOwnPropertySlot bypassing the static tables. Always perform a lookup that will check both property storage & static tables. If the object does contain the property, check explicitly for the value we're intending to suppress.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160602/1af12001/attachment.html>
More information about the webkit-unassigned
mailing list