[Webkit-unassigned] [Bug 158191] WebRTC: Update RTCPeerConnection.addTrack() to create (or reuse) an RTCRtpTransceiver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158191

--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 280254
  --> https://bugs.webkit.org/attachment.cgi?id=280254
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280254&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.h:67
> +    Vector<RefPtr<RTCRtpSender>> getSenders() const override { return m_transceiverSet->getSenders(); }
> +    Vector<RefPtr<RTCRtpReceiver>> getReceivers() const { return m_transceiverSet->getReceivers(); }

Can these return a reference to a const Vector: "const Vector<RefPtr<...>>&"?

> Source/WebCore/Modules/mediastream/RTCPeerConnection.h:68
> +    const Vector<RefPtr<RTCRtpTransceiver>>& getTransceivers() const override { return m_transceiverSet->list(); }

Can this be final instead of override?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160601/f13e7b4c/attachment.html>