[Webkit-unassigned] [Bug 157973] PlatformDisplay crash when calling egl_terminate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157973

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #280238|review?                     |review+
              Flags|                            |

--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 280238
  --> https://bugs.webkit.org/attachment.cgi?id=280238
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280238&action=review

OK.

> Source/WebCore/platform/graphics/PlatformDisplay.cpp:169
> +    std::atexit([] { PlatformDisplay::sharedDisplay().terminateEGLDisplay(); });

Since this is not a static function, I think it make more sense to not use PlatformDisplay::sharedDisplay() here. You say you cannot capture |this| here, but I don't understand why not; did you try writing it this way:

std::atexit([this] { this->terminateEGLDisplay(); });

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160601/ea01d0d7/attachment.html>