[Webkit-unassigned] [Bug 159398] [test262] Fixing mapped arguments object property test case

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159398

--- Comment #39 from Caio Lima <ticaiolima at gmail.com> ---
(In reply to comment #30)
> Comment on attachment 284980 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284980&action=review
> 
> > Source/JavaScriptCore/runtime/GenericArguments.h:59
> > +private:
> > +
> 
> WebKit coding style does not leave a blank line here.
> 
> > Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:165
> > +    if (!canDeletePropertyById(thisObject, exec, ident))
> > +        return false;
> 
> This means looking up every property twice when deleting it, once to see if
> it can be deleted and then a second time to actually delete it. Is there any
> way to get the correct behavior without adding the double lookup?

I can't see an clear way to do that, but I am totally open to discuss about a viable solution =). As I commented above, the lookup is necessary because I want to avoid create a new auxiliar data structure to store if the argument[i] is configurable. Since these properties can be sparse, this data structure need to be dynamic such as m_overrides. IMHO the complexity of this kind of optimization isn't worth enough when comparing with readability.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160801/062b484f/attachment.html>