[Webkit-unassigned] [Bug 159398] [test262] Fixing mapped arguments object property test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 31 21:44:49 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=159398

--- Comment #30 from Darin Adler <darin at apple.com> ---
Comment on attachment 284980
  --> https://bugs.webkit.org/attachment.cgi?id=284980
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284980&action=review

> Source/JavaScriptCore/runtime/GenericArguments.h:59
> +private:
> +

WebKit coding style does not leave a blank line here.

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:165
> +    if (!canDeletePropertyById(thisObject, exec, ident))
> +        return false;

This means looking up every property twice when deleting it, once to see if it can be deleted and then a second time to actually delete it. Is there any way to get the correct behavior without adding the double lookup?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160801/b3a622af/attachment-0001.html>


More information about the webkit-unassigned mailing list