[Webkit-unassigned] [Bug 160389] [GTK] Move the redirected XComposite window to the web process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160389

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 284964
  --> https://bugs.webkit.org/attachment.cgi?id=284964
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284964&action=review

So it makes AC mode not suck? :)

This one really should be looked at by a graphics reviewer; if it gets stuck awaiting review, you can ping me after a few days.

> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:66
> +bool PlatformDisplayX11::supportsXComposite()

Can you make it const, as it should be, if you make m_supportsXComposite mutable? Or does the call to XCompositeQueryExtension prevent that?

> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:75
> +bool PlatformDisplayX11::supportsXDamage(int& damageEventBase)

Can you make it const, as it should be, if you make m_damageEventBase mutable? Or does the call to XDamageQueryExtension prevent that?

> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp:79
> +        m_supportsXDamage = XDamageQueryExtension(m_display, &eventBase, &errorBase);

EFL build is failing here:

lib/libwebcore_efl.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/x11/PlatformDisplayX11.cpp.o):PlatformDisplayX11.cpp:function WebCore::PlatformDisplayX11::supportsXDamage(int&): error: undefined reference to 'XDamageQueryExtension'
collect2: error: ld returned 1 exit status

We link with ${X11_Xdamage_LIB} in WebCore/PlatformGtk.cmake, but EFL does not; you'll need to add it to WebCore_LIBRARIES.

> Source/WebKit2/UIProcess/gtk/XDamageNotifier.cpp:75
> +GdkFilterReturn XDamageNotifier::filterXDamageEvent(GdkXEvent* event, GdkEvent*, XDamageNotifier* notifier)

Since it doesn't access any member variables, I would move it outside the class.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160731/e1c5822f/attachment.html>