[Webkit-unassigned] [Bug 160365] New: Refactor ContentFilterUnblockHandler to allow platform implementations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160365

            Bug ID: 160365
           Summary: Refactor ContentFilterUnblockHandler to allow platform
                    implementations
    Classification: Unclassified
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aperez at igalia.com

Following up bug 154553:

>> I think we should split the patch, enabling content extensions first, and
>> unskipping the layout tests, and then another patch to add the GTK+ API. It
>> would help a lot to start working on  a patch for epiphany in parallel.
>
> ACK. I have been working on the split, and while doing the first part which
> unskips the layout test I noticed that there was missing some changes to the
> CMake files to have ENABLE_CONTENT_FILTERING defined, and once that was enabled
> it was needed to add more files to the build, and ContentFilterUnblockHandler
> needs refactoring as it's only implemented for Cocoa.
>
> The refactor be a separate patch as well, which will add a port-agnostic
> ContentFilterUnblockHandlerBase, and move the Cocoa-specific implementation
> into WebCore/platform/cocoa/ContentFilterUnblockHandler.{h,mm}. After that
> is done, we can add an implementation for the GTK port.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160729/501ed769/attachment.html>