[Webkit-unassigned] [Bug 160223] AX: Media controls accessibility improvement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160223

--- Comment #17 from chris fleizach <cfleizach at apple.com> ---
(In reply to comment #16)
> Comment on attachment 284671 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284671&action=review
> 
> >>> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:424
> >>> +        timeline.step = 1;
> >> 
> >> While 1 will be a better value than .01 for some movies, it will be much worse for very short files, and it still won't be great for long files. Can you set it to a percentage of the duration in updateDuration instead? You may want to vary the percentage based on duration, e.g. 1% of a 90 second file is almost a second but 1% of a 90 minute is almost a minute, but a I'll bet you can come up with reasonable values with some experimentation.
> > 
> > We have come up with some cases that, let me know your thought:
> > 1. If video is less then 10sec we do 0.5 second step
> > 2. If video is between 10sec to 1min we do 1 second step
> > 3. If video is between 1min to 10min we do 10 second step
> > 4. If video is between 10min to 60min we do 30 second step
> > 5. If video is more than 60min we do 60 second step.
> 
> Now that I have played around with this, I don't think .step is the right
> way to fix this, is it possible to fix this problem with something else?
> While .step makes the slider more usable from the keyboard, it also makes it
> almost unusable as a media timeline slider because it is not possible to
> seek to specific times: e.g. in an hour long video it is only possible to
> seek to every minute. 
> 
> Play around with this fiddle to see what I mean:
> https://jsfiddle.net/jvL5nnnd

This was my concern too. Right now we're either making it impossible for KB users to use it or making it useless as a slider

Can we add a keyboard event handler for left/right arrow keys that will adjust the value appropriately while leaving the step as it currently is?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160728/e281b834/attachment.html>