[Webkit-unassigned] [Bug 160223] AX: Media controls accessibility improvement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160223

--- Comment #12 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 284667
  --> https://bugs.webkit.org/attachment.cgi?id=284667
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284667&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1182
> +        if (this.video.muted) {
> +            this.video.muted = false;
> +            this.controls.muteButton.setAttribute('aria-checked', 'false');
> +        }
> +        this.video.volume = this.controls.volume.value;
> +        this.controls.volume.setAttribute('aria-valuetext', parseInt(this.controls.volume.value * 100) + '%');

It is unfortunate to have yet another function that checks/changes this.video.muted, sets this.video.volume,  and sets the aria-valuetext. Can you make a helper function that does these common steps and call it from your new event handler and the existing event handler that have duplicate code?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160727/fce2dda4/attachment.html>