[Webkit-unassigned] [Bug 160155] AX: AccessibilityRenderObject is adding duplicated children when CSS first-letter is being used.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 25 00:24:01 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=160155

--- Comment #7 from Nan Wang <n_wang at apple.com> ---
(In reply to comment #6)
> Comment on attachment 284464 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284464&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:226
> > +    // Sometimes with CSS first-letter selector, we were adding the same text node twice.
> 
> sorry to be a jerk, but this seems like it should be in
> firstChildConsideringContinuation shouldn't it
> 
> also if firstChild() returns null, how will nextSibling() be called

I think in this case we don't want to add children for the inline element continuation. The real node will be handled in its parent level.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160725/8a1cf29d/attachment.html>


More information about the webkit-unassigned mailing list