[Webkit-unassigned] [Bug 160023] [GTK] Fix some video/canvas tests that should be passing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160023

--- Comment #20 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #19)
> Comment on attachment 284333 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284333&action=review
> 
> > LayoutTests/media/video-canvas.js:4
> > +        return window.testRunner.videoCanvasPixelComparisonTolerance;
> 
> Crazy thought, is it possible to detect WebKitGTK from JavaScript (e.g.
> using user-agent string?). If so, it may be simpler to return 6 if we detect
> WebKitGTK / WebKitEFL and 2 otherwise. It would be pure JS and would not
> require any TestRunner functionality.

I don't think so, because of websites parsing UA string and assuming there are only 3 browsers in the world, we pretend to be safari in our UA. Of course we could do some hacks like checking if there's Linux in the UA, and assume that's EFL/GTK+, but I don't see how that's better than exposing the property in the TestRunner. What we could do, though is modify the user agent from WTR using WKPageSetApplicationNameForUserAgent, appending something like WebKitTestRunnerGTK, WebKitTestRunnerEFL, WebKitTestRunnerFoo and then parse the UA string from tests to detect the port. Good thing of this is that it would be more generic solution, we could add helper functions to the common js files isGtk(), isEfl(), etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160723/3799841e/attachment.html>