[Webkit-unassigned] [Bug 160088] Simplify ThreadData* management for a Bucket inside ParkingLot.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160088

Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #284349|review?                     |review-
              Flags|                            |

--- Comment #3 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 284349
  --> https://bugs.webkit.org/attachment.cgi?id=284349
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284349&action=review

I don't like this change.  It makes the code more confusing, and I believe it's a regression since we want FIFO ordering.

> Source/WTF/ChangeLog:32
> +        If we don't worry about fairness of dequeue of enqueued threads
> +        aka we don't guranntee FIFO order, we could use a simple
> +        BitMap to keep track on equeued ThreadData* in Bucket
> +        (kind of simplied vector). 

I disagree, we want FIFO order.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160722/a8de0810/attachment-0001.html>