[Webkit-unassigned] [Bug 128928] Improve GDB backtrace generation for GTK/EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128928

--- Comment #15 from Philippe Normand <pnormand at igalia.com> ---
(In reply to comment #13)
> Comment on attachment 283647 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=283647&action=review
> 
> >> Tools/Scripts/process-linux-coredump:26
> >> +    full_path = os.path.join(destination_directory, 'core-pid_%d.dump'  % int(pid))
> > 
> > Why do you need to convert the pid to int? Why not just use %s instead? Or the script could receive the path already built no?
> 
> No strong reason for the conversion. The script cannot receive the full path
> already built because the script invocation is hardcoded in the core_pattern.
> 

Ah sorry this can be improved indeed. I'll update the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160722/9d8301c0/attachment-0001.html>