[Webkit-unassigned] [Bug 160017] REGRESSION (r203142): Layout test js/regress-139548.html is 10x slower.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 21 10:40:21 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=160017

--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
(In reply to comment #1)
> The tests seems quite sensible to the JSC_stackSizeInBytes value.
> 
> This patch makes it finish in 10 seconds instead of 25:
> 
> 
> --- a/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
> +++ b/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
> @@ -75,7 +75,7 @@ def main(argv, stdout, stderr):
>  
>      try:
>          # Force all tests to use a smaller stack so that stack overflow
> tests can run faster.
> -        stackSizeInBytes = int(1.5 * 1024 * 1024)
> +        stackSizeInBytes = int(0.5 * 1024 * 1024)
>          options.additional_env_var.append('JSC_maxPerThreadStackUsage=' +
> str(stackSizeInBytes))
>         
> options.additional_env_var.append('__XPC_JSC_maxPerThreadStackUsage=' +
> str(stackSizeInBytes))
>          run_details = run(port, options, args, stderr)

We can't do this because it will cause other tests to fail.  This setting here is a broad brush and was picked to be 1.5M because that was found to be the minimum needed for all tests to pass.

Let's see if we can make this test behave better while still maintaining its original testing purpose.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160721/6a1261da/attachment.html>


More information about the webkit-unassigned mailing list