[Webkit-unassigned] [Bug 159827] run-webkit-tests should trigger a spindump when WebContent process is unresponsive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159827

--- Comment #19 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 284131
  --> https://bugs.webkit.org/attachment.cgi?id=284131
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284131&action=review

> Tools/Scripts/webkitpy/port/ios.py:434
> +            self._executive.run_command(['sudo', '-n', 'spindump', str(pid), '10', '-file', self.results_directory() + '/' + parsed_filename + '.spindump.txt'])

Among other reasons it is good form to make use of full filesystem paths when invoking a command (even though the underlying implementation of Executive.run_command() ultimately invokes execvp(3), which uses the PATH environment variable to resolve program paths). In particular, we should use the full filesystem path for both sudo and spindump, /usr/bin/sudo and /usr/sbin/spindump, respectively.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160721/acafce40/attachment.html>