[Webkit-unassigned] [Bug 159827] run-webkit-tests should trigger a spindump when WebContent process is unresponsive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159827

--- Comment #15 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 284062
  --> https://bugs.webkit.org/attachment.cgi?id=284062
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284062&action=review

>> Tools/Scripts/webkitpy/port/ios.py:434
>> +        spindump_process = subprocess.Popen(['sudo', '-A', 'spindump', str(pid), '10', '-file', self.results_directory() + '/' + parsed_filename + '.spindump.txt'], stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
> 
> Can we make use of option -n instead of -A to have sudo exit with an error if the command requires a password?
> 
> From some experiments, "sudo -n" seems to work and avoids prompting for a password if either the current user has password-less sudo access (marked NOPASSWD: ALL in the sudoers file) or if "sudo -n" was invoked within the password prompt timeout period. If a password is required then sudo will exit with an exit code of 1.

sudo -n may be a better fit, particularly if people don't define SUDO_ASKPASS.  I suppose that what this ultimately comes down to is which functionality is preferred.  Do we want the user to be prompted if SUDO_ASKPASS is defined through whatever mechanism they personally provided in that script, and fail if such a method is not defined, or simply fail if the command cannot get achieve sudo permissions?  For the time being, I think -n is probably the safer choice, although it may be less useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160720/4f9154e1/attachment-0001.html>