[Webkit-unassigned] [Bug 159928] [GStreamer] Support a direct GPU-to-GPU copy of video textures to WebGL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 20 08:13:11 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=159928

--- Comment #5 from Olivier Blin <olivier.blin at softathome.com> ---
(In reply to comment #4)
> > Though, Miguel already has concerns about this, since it does not support
> > the video rotation flags.
> > Miguel suggests to reuse cairo_gl_surface_create_for_texture() instead, like
> > in nativeImageForCurrentTime(), and let cairo do the texture copy and
> > rotating if needed.
> 
> As I explained to you, we need to take into consideration the video
> orientation flag when we are rendering video frames with accelerated
> composition enabled. This is because the frames we get from the video are
> not following the video orientation in the acc composition case, and we
> apply the appropriate rotation when painting them. This is done in the video
> element, in the canvas, and needs to be done in webgl as well.

Yep, I posted my current state of work for reference, I will rework as you advised.

> Also, on a fast look to the patch I realized that you are not using the
> appropriate mutex when accessing the video sample.

Ok, isn't one needed in the GSTREAMER_GL case of paintToTextureMapper() as well?

Thanks for your input

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160720/b212a05d/attachment.html>


More information about the webkit-unassigned mailing list