[Webkit-unassigned] [Bug 159910] AX: Incorrect behavior for word related text marker functions when there's collapsed whitespace

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 19 10:16:51 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=159910

--- Comment #10 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 284009
  --> https://bugs.webkit.org/attachment.cgi?id=284009
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284009&action=review

>>> Source/WebCore/accessibility/AXObjectCache.cpp:1590
>>> +        bool cumulateEnough = validateOffset ? cumulativeOffset + lastStartOffset >= offset : cumulativeOffset >= offset;
>> 
>> the name of this variable is strange: cumulateEnough
>> what purpose do you want it to serve?
>> 
>> it seems like it could be "bool validOffset"
> 
> This is to check if we have cumulated enough characters so that we can break early.

bool offsetLimitReached

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160719/33f7a1bb/attachment.html>


More information about the webkit-unassigned mailing list