[Webkit-unassigned] [Bug 155255] MemoryPressureHandler doesn't work if cgroups aren't present in Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155255

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #283624|review?                     |review+
              Flags|                            |

--- Comment #37 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 283624
  --> https://bugs.webkit.org/attachment.cgi?id=283624
Try to fix builds

View in context: https://bugs.webkit.org/attachment.cgi?id=283624&action=review

> Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:196
> +bool MemoryPressureHandler::tryEnsureEventFD()

tryEnsure seems a bit weird name to me.

> Source/WebKit2/NetworkProcess/NetworkProcess.cpp:196
> +void NetworkProcess::initializeNetworkProcess(NetworkProcessCreationParameters&& parameters)

Seems unrelated

> Source/WebKit2/PluginProcess/PluginProcess.cpp:142
> +    memoryPressureHandler.install();

I understand you move this here because you need to set the handle before the install, I hope this does not add any race condition I've seen before when moving stuff like this.

> Source/WebKit2/UIProcess/linux/MemoryPressureMonitor.cpp:47
> +static const size_t notSet = static_cast<size_t>(-1);

Instead of notSet, consider making  lowWatermarkPages() and calculateMemoryAvailable() return an Optional<size_t>.

> Source/WebKit2/UIProcess/linux/MemoryPressureMonitor.cpp:189
> +        // See https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=34e431b0ae398fc54ea69ff85ec700722c9da773

I'd find more useful to have this link just above the function definition.

> Source/WebKit2/UIProcess/linux/MemoryPressureMonitor.cpp:195
> +    return ((memoryTotal - memoryAvailable) * 100) / memoryTotal;

Do we have any guarantee that memoryTotal is not 0?

Do we have any guarantee that memoryTotal > memoryAvailable ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160718/6a3c001a/attachment.html>