[Webkit-unassigned] [Bug 159855] New: Change how exceptions are logged in the JS console to not look redundant and silly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159855

            Bug ID: 159855
           Summary: Change how exceptions are logged in the JS console to
                    not look redundant and silly
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: beidson at apple.com

Change how exceptions are logged in the JS console to not look redundant and silly.

This is needed with work on https://bugs.webkit.org/show_bug.cgi?id=159822, which is making exception messages more rich.

An example of how this work effects console.log can be found here - https://bugs.webkit.org/show_bug.cgi?id=159847#c2

CONSOLE MESSAGE: line 14: An invalid value was passed to an operation or assigned to an attribute.: An invalid value was passed to an operation or assigned to an attribute.

The code responsible is in JSDOMBinding.cpp:

void reportException(ExecState* exec, Exception* exception, CachedScript* cachedScript, ExceptionDetails* exceptionDetails)
...
        errorMessage = exceptionBase->message() + ": "  + exceptionBase->description();

For Exceptions that have adopted the "description as message" mode, the message and the description are the same.

This can all get cleaned up once the task represented by 159822 is complete, but for now we should do something a little different for the new exceptions vs the old ones.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160716/2bb44c33/attachment.html>