[Webkit-unassigned] [Bug 128928] Improve GDB backtrace generation for GTK/EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128928

--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 283647
  --> https://bugs.webkit.org/attachment.cgi?id=283647
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283647&action=review

> Source/WebKit2/UIProcess/API/C/gtk/WKContextPrivateGtk.cpp:41
> +pid_t WKContextGetNetworkProcessIdentifier(WKContextRef contextRef)
> +{
> +    return toImpl(contextRef)->networkProcessIdentifier();
> +}
> +
> +pid_t WKContextGetDatabaseProcessIdentifier(WKContextRef contextRef)
> +{
> +    return toImpl(contextRef)->databaseProcessIdentifier();

Why is this specific to GTK+? Why don't we add this to WKContext.cpp and WKContextPrivate.h?

> Source/WebKit2/UIProcess/API/C/gtk/WKPagePrivateGtk.cpp:37
> +pid_t WKPageGetProcessIdentifier(WKPageRef pageRef)
> +{
> +    return toImpl(pageRef)->processIdentifier();
> +}

Ditto, this could be added to WKPage.cpp and WKPagePrivate.h, since this is exposing cross-platform API

> Tools/Scripts/process-linux-coredump:26
> +    full_path = os.path.join(destination_directory, 'core-pid_%d.dump'  % int(pid))

Why do you need to convert the pid to int? Why not just use %s instead? Or the script could receive the path already built no?

> Tools/Scripts/webkitpy/port/linux_get_crash_log_unittest.py:49
>          core_pattern = os.path.join(core_directory, "core-pid_%p-_-process_%E")
> +        core_pattern = "|%s %%p /path/to/coredumps" % process_coredump_script_path

Shouldn't you remove the previous core_pattern assignation?

> Tools/WebKitTestRunner/TestController.cpp:1487
>      pid_t pid = WKContextGetNetworkProcessIdentifier(m_context.get());

Ah, mac already has an impl of this. In that case it should be moved to the cross-platform files, I think, instead of duplicating it in GTK specific files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160716/9ca44dce/attachment.html>