[Webkit-unassigned] [Bug 159405] [GTK] Painting a video into a canvas doesn't work when accelerated compositing is enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159405

--- Comment #18 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 282885
  --> https://bugs.webkit.org/attachment.cgi?id=282885
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=282885&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:733
> +    // Ensure that we destroy the surface before unmapping the video frame.
> +    surface.release();

release() leaks the surface, it doesn't destroy it. What you want is

surface = nullptr;

but I'm not sure this is enough, though. I don't know why it's needed to destroy the surface before unmapping the frame, but the cairo context owns a reference to the surface , so even if you clear the smart pointer the surface will still be alive.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160706/5296146e/attachment.html>