[Webkit-unassigned] [Bug 159445] AX: Use UNLIKELY around AXObjectCache::accessibilityEnabled()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159445

--- Comment #2 from Joanmarie Diggs (irc: joanie) <jdiggs at igalia.com> ---
Related to this:

There are a number of places in WebCore, but outside of the accessibility code, in which Document::existingAXObjectCache() is called without first checking AXObjectCache::accessibilityEnabled().

If the checks that are present (e.g. in RenderBlockLineLayout.cpp, RenderImage.cpp) are indeed worth doing, they are potentially also worth doing in RenderBlock.cpp and RenderWidget.cpp, and RenderText.cpp, and RenderMenuList.cpp, and .... 

Or we could instead just add a single:

    if (UNLIKELY(AXObjectCache::accessibilityEnabled()))

to Document::existingAXObjectCache().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160706/1ad191ce/attachment.html>