[Webkit-unassigned] [Bug 153116] Need ability to specify alternate image for AutoFill button in input fields

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 29 09:26:20 PST 2016


--- Comment #28 from Darin Adler <darin at apple.com> ---
(In reply to comment #27)
> Taking your above comments into consideration, we only need the
> updateAutoFillButton() method that looks like:

Yes, that looks right.

> > > Source/WebCore/testing/Internals.idl:64
> > > +enum AutoFillButtonType {
> > > +    "AutoFillButtonTypeNone",
> > > +    "AutoFillButtonTypeContacts",
> > > +    "AutoFillButtonTypeCredentials"
> > > +};
> > 
> > I would have just used the strings "none", "credentials", and "contacts".
> > Not sure why the long strings with capital letters are better.
> I also prefer shorter strings as long as they are clear. In Internals.idl,
> there are strings with capital letters and there are strings with lower case
> for enum, what is the recommended practice for this?

I think there’s some confusion between true enums in C++ code, where the values need to avoid conflicting with each other and look right in C++ code context, enums in DOM APIs and enums in our internals file.

1) For enums in C++ code, they need to not collide with each other so we either need to prefix values with the type, or use enum class. And we use capital letters in those by convention.

2) For enums in DOM APIs, we need to match the style of the DOM specifications, which means we use ALL_CAPITAL_LETTERS style for the values. There is also some issue of name conflict there.

3) For these enums for internals, what we are calling enums is actually just a list of string values. There is no need to make them unique, prefix them with a type name, or anything else like that.

So for these, in category (3) I think we should use lower case strings. When there is more than one word, not sure if we should use spaces (like normal English), hyphens (like CSS identifiers), underscores, or capital letters (like local variables in C++ code). But really no need to use capital letters.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160129/3a71e179/attachment.html>

More information about the webkit-unassigned mailing list