[Webkit-unassigned] [Bug 138468] [GTK] WebProcess crashes when quickly attempting many DnD operations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 29 07:01:47 PST 2016


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #270206|                            |review?
              Flags|                            |

--- Comment #44 from Mario Sanchez Prada <mario at webkit.org> ---
Created attachment 270206
  --> https://bugs.webkit.org/attachment.cgi?id=270206&action=review
Patch to fix the build breakage with GTK+ < 3.16

It seems we overlooked the fact that gtk_drag_cancel() is available from GTK+ 3.16, meaning we broke the build for older versions of GTK from 3.6 onwards.

Unfortunately, there's no clear alternative to gtk_drag_cancel() in GTK to reliably cancel DnD operations so we are proposing this patch that basically restores the old behaviour for builds using old versions of GTK+, while keeping it fixed for newer ones. While this is non-optimal, it seems like the best way to fix this problem (which is not easy to reproduce anyway) at least in the short term.

Please review, thanks!

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160129/fea5b823/attachment.html>

More information about the webkit-unassigned mailing list