[Webkit-unassigned] [Bug 153554] [webkitdirs] Clarify logic behind is{PortName} functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153554

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #270031|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 270031
  --> https://bugs.webkit.org/attachment.cgi?id=270031
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270031&action=review

> Tools/ChangeLog:22
> +        * Scripts/webkitdirs.pm:
> +        (determinePortName):
> +        (portName):
> +        (isEfl):
> +        (isGtk):
> +        (isWinCairo):
> +        (isAppleMacWebKit):
> +        (isAppleWinWebKit):
> +        (isIOSWebKit):
> +        (cmakeBasedPortName):
> +        (checkForArgumentAndRemoveFromArrayRef): Deleted.
> +        (isX86_64): Deleted.
> +        (isCrossCompilation): Deleted.
> +        (createiOSSimulatorDevice): Deleted.
> +        (buildCMakeProjectOrExit): Deleted.

In a good quality change log, we make comments saying what we did to each function.

>> Tools/Scripts/webkitdirs.pm:103
>> +    IOS      => "IOS",
> 
> This should probably be iOS.

Yes, it should.

> Tools/Scripts/webkitdirs.pm:1060
> +        $portName = "AppleWin";

Don’t we want to use the constant here?

> Tools/Scripts/webkitdirs.pm:1064
> +            $portName = "IOS";

Don’t we want to use the constant here?

> Tools/Scripts/webkitdirs.pm:1066
> +            $portName = "Mac";

Don’t we want to use the constant here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160127/2e2dfe0f/attachment.html>