[Webkit-unassigned] [Bug 153463] [mips] don't save to a callee saved register too early

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153463

--- Comment #6 from Julien Brianceau <jbriance at cisco.com> ---
Comment on attachment 269812
  --> https://bugs.webkit.org/attachment.cgi?id=269812
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269812&action=review

> Source/JavaScriptCore/offlineasm/mips.rb:562
> +        preList << Instruction.new(operand.codeOrigin, "move", [MIPS_GP_REG, MIPS_GPSAVE_REG])

I'm not a huge fan of this. Instead, can you add something like ' emit "move $s4, $gp" ' at the end of the pushCalleeSaves macro ?
And also take the opportunity to set CalleeSaveRegisterCount to 1 for MIPS and just save/restore $s4 register instead of the $s0-$s4 range.

It seems to work fine on my mips board and slightly reduces the number of generated opcodes in LLInt.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160127/66a3109f/attachment.html>