[Webkit-unassigned] [Bug 153467] Sort incoming commits via date instead of revision number

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153467

--- Comment #4 from Jason Marcell <jmarcell at apple.com> ---
(In reply to comment #2)
> Comment on attachment 269817 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=269817&action=review
> 
> r=me w/ passing tests! :)
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:200
> > +            this.recordedCommits = newCommits.concat(this.recordedCommits).sort(function(a, b) { return a.date - b.date; });
> 
> I'm assuming this is the case, but just to be sure: these dates are either
> stored as integers or are data types that have logic to handle arithmetic
> operations and give correct results?

Yes, that is the case.

> 
> Actually, tests for this would completely eliminate my concern :)

I've added tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160127/4a1f5ff9/attachment-0001.html>