[Webkit-unassigned] [Bug 153405] [GTK] Implement overlay scrollbars

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153405

--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #11)
> I do want to strongly encourage you to consider making tests. Don't make the
> same mistake I did!! I assure you that our experience on Mac has been that
> these behaviors can be subtle enough that we have introduced regressions
> that took a long time to notice -- I imagine that this will be true for you
> too. Especially if you support both "legacy" and "overlay" scrollbars (more
> things to get wrong). Since we have already experienced a number of
> regressions over the years it feels inevitable to me we will  accidentally
> break each other's code at some point. All of that will be less painful with
> tests.

I agree.

> I regret not figuring this out a long time ago, and it still nags at me even
> though I have a ton of other things to work on. Simon and I were talking
> today. Maybe there is a way to add tests that just turn on overlay scrollbar
> logging, and then the scrollbars log something every time they appear or
> disappear? Or add some way to query current overlay scrollbar state (visible
> or not, hover-appearance or not, etc)? If you take the lead on fleshing this
> out, I can implement the Mac support.

I also thought about it. I think we could add a mock scroll animator that logs all the events somehow (mouse entered/exited scrollable area, mouse entered/existed scrollbar, etc.). That behavior should be common to all ports, no matter if overlay scrollbars are used or not.

> Besides this strong encouragement, I also have to insist that you change the
> name of ScrollAnimatorNone. It seems much more like the presence of scroll
> animations than the absence! I appreciate the desire to make it more
> cross-platform-friendly, but I think that ScrollAnimatorGTK would be a much
> better name.

Ok, I'll add ScrollAnimatorGtk then, if EFL eventually wants to use our overlay scrollbars implementation we will find the way to share the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160126/d0e7b16f/attachment-0001.html>