[Webkit-unassigned] [Bug 153352] Overlay scrollbars should always use the whole contents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153352

--- Comment #15 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #13)
> Comment on attachment 269565 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=269565&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        They are currently respecting the scroll corner. In the case of
> 
> Nit: it would be good if you paste your Bugzilla explanation into the
> changelog, to make it easier to understand why you're making this change.
> 
> > Source/WebCore/rendering/RenderLayer.cpp:2824
> > +    if (showsOverflowControls())
> 
> Can you add a comment here to indicate that this is to avoid the weird blank
> space between the two scrollbars?

This check is wrong, I should be checking that current scrollbars are overlay scrollbars. I'll add the comment when I update the patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160125/8d8e3773/attachment.html>