[Webkit-unassigned] [Bug 153405] [GTK] Implement overlay scrollbars

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153405

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 269692
  --> https://bugs.webkit.org/attachment.cgi?id=269692
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269692&action=review

> Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:238
> +    m_usesOverlayScrollbars = g_strcmp0(g_getenv("GTK_OVERLAY_SCROLLING"), "0");

Is this really the right test...? It's not a style property? I assumed this variable was to turn off overlay scrolling for debugging purposes. Are all themes expected to implement overlay scrollbars?

I'm halfway pleased that the technical limitation of threaded compositor necessitates implementing overlay scrollbars, because now we have overlay scrollbars. But it's disappointing that threaded compositor will prevent us from rendering non-overlay scrollbars. I expect this could cause scrollbars to look quite bad with anything besides Adwaita or Ambiance. Can you or Yoon explain the technical limitation here?

> Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:432
> +#if GTK_CHECK_VERSION(3, 19, 8)

I don't understand this version check. 3.19.7 was released last week; I don't see any scrollbar-related changes since then?

I would just get rid of the check; it's enough that the code works with GTK+ master, that's what you and I are going to use, we're the people testing it so optimize for us. Otherwise I'd have to manually remove the check to test this code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160125/b77b9026/attachment.html>