[Webkit-unassigned] [Bug 153116] Need ability to specify alternate image for AutoFill button in input fields

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 24 15:04:38 PST 2016


--- Comment #17 from Darin Adler <darin at apple.com> ---
Comment on attachment 269302
  --> https://bugs.webkit.org/attachment.cgi?id=269302
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=269302&action=review

>> Source/WebCore/html/HTMLInputElement.h:436
>> +    AutoFillButtonType m_autoFillButtonType;
> This is only one bit. It’s not great that it’s going to make every HTMLInputElement 32 bits bigger (or more). Notice that all the fields around this are using bitfields to keep things cheap. Not OK to make every input element so much bigger. I think this should be:
>     unsigned m_autoFillButtonType : 1; // AutoFillButtonType
> To match how we do things in the rest of the class.
> We could also consider combining this with

We could also consider combining this with the flag that says there is an auto-fill button. We don’t need to support setting the type when showAutoFillButton is false, and over time that could save us some bits.

>> Source/WebCore/html/TextFieldInputType.cpp:644
>> +            createAutoFillButton(autoFillButtonType);
> This looks wrong. If the auto fill button type has changed, I don’t see code to cause the old one to be destroyed and a new one of the correct type to be created.

We should make a test case that shows the auto-fill button correctly changing even when the attribute is changed after the fact.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160124/1fcd611f/attachment.html>

More information about the webkit-unassigned mailing list