[Webkit-unassigned] [Bug 153331] Handle soft spaces after accepted candidates

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 24 11:58:35 PST 2016


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #269518|review?                     |review+
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 269518
  --> https://bugs.webkit.org/attachment.cgi?id=269518

View in context: https://bugs.webkit.org/attachment.cgi?id=269518&action=review

> Source/WebCore/editing/Editor.cpp:3567
> +    if (!acceptedCandidate.replacement.endsWith(" "))

Should be endsWith(' ') to avoid unnecessary work.

> Source/WebCore/editing/Editor.cpp:3568
> +        insertText(String(" "), 0);

Should be ASCIILiteral instead of String, although not sure how helpful that optimization is in cases like this.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160124/571e52f9/attachment-0001.html>

More information about the webkit-unassigned mailing list